Attention is currently required from: flichtenheld, plaisthos. mattock has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/811?usp=email )
Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 7: (5 comments) Patchset: PS7: I believe all the issues have now been fixed. File doc/t_server_null.rst: http://gerrit.openvpn.net/c/openvpn/+/811/comment/2d1c9ea4_216d5c5f : PS4, Line 129: Note that all ovpnlwip test names need to include a "_lwip" suffix: without if > "without it" Fixed. File tests/lwip_client_up.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/d09bbc1c_eac12c14 : PS4, Line 4: if ! grep "$ifconfig_local" ./$test_name.ips; then > Should use grep -q Fixed. File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/05185aa6_2c43584f : PS4, Line 61: echo "ERROR: pinging one or more openvpnlwip client IP addresses failed!" > This should use FAIL since it actually causes the test to fail. […] Fixed. File tests/t_server_null_default.rc: http://gerrit.openvpn.net/c/openvpn/+/811/comment/ab8689e8_99bd56fe : PS4, Line 22: LWIPOVPN_PATH="${LWIPOVPN_PATH:-lwipovpn}" > This is extremely misleading. This seems to indicate that you can override > `LWIPOVPN_PATH`. […] I actually mentioned this in my comment to patchset 2, quoted below in full: --- It is now possible to do LWIPOVPN_PATH=/some/path/to/lwipovpn make check To use a custom location. It would have been nicer to be able to override it it t_server_null.rc, but that file gets loaded too late for it to have any practical effect on the actual client command-lines. --- This override mechanism is already used in openvpn-buildbot, see https://github.com/OpenVPN/openvpn-buildbot/blob/master/buildbot-host/buildmaster/master.cfg#L506 I've added a comment to the file that explains how this works. The details are already lost in the mists of time, but I remember not seeing an obvious alternative solution to this that would not have involved a fair amount of refactoring. Hence I opted for this simple solution which I agree was misleading, especially when not documented. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 7 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 09 Jan 2025 12:13:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
