Attention is currently required from: kallisti5, plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/687?usp=email )

Change subject: Haiku: Introduce basic platform / tun support
......................................................................


Patch Set 2:

(1 comment)

File src/openvpn/tun.c:

http://gerrit.openvpn.net/c/openvpn/+/687/comment/253bd262_14f53440 :
PS2, Line 1924:                          "/dev/%s/%d", dev, i);
It might be nicer to put the `"/"` into a variable (e.g. `sep`) and reduce the 
duplicated code this way?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/687?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9a278374f492a538f0c174ced1746c3b1f82b8c9
Gerrit-Change-Number: 687
Gerrit-PatchSet: 2
Gerrit-Owner: kallisti5 <a...@terarocket.io>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: kallisti5 <a...@terarocket.io>
Gerrit-Comment-Date: Tue, 26 Nov 2024 17:13:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to