Attention is currently required from: flichtenheld, kallisti5, plaisthos.

cron2 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/687?usp=email )

Change subject: Haiku: Introduce basic platform / tun support
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

Patchset:

PS4:
there is this XXX comment which needs attention


File src/openvpn/tun.c:

http://gerrit.openvpn.net/c/openvpn/+/687/comment/ad542d93_0dcbfd0d :
PS4, Line 1637:         /* XXX: Need to add ifconfig_remote_netmask since right 
now it is just NULL */
this XXX line irks me.  What does it mean?  Who needs to do something here?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/687?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9a278374f492a538f0c174ced1746c3b1f82b8c9
Gerrit-Change-Number: 687
Gerrit-PatchSet: 4
Gerrit-Owner: kallisti5 <a...@terarocket.io>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: kallisti5 <a...@terarocket.io>
Gerrit-Comment-Date: Wed, 27 Nov 2024 10:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to