Attention is currently required from: flichtenheld, kallisti5, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/687?usp=email )
Change subject: Haiku: Introduce basic platform / tun support ...................................................................... Patch Set 6: Code-Review+2 (2 comments) Patchset: PS6: LGTM. Tested via buildbots and GHA, and neither complain that we accidently broke something (well, uncrustify complains, but I'll fix that on the fly as it's "just whitespace") File src/openvpn/tun.c: http://gerrit.openvpn.net/c/openvpn/+/687/comment/2ba4bc97_2a2926cb : PS4, Line 1637: /* XXX: Need to add ifconfig_remote_netmask since right now it is just NULL */ > It's a common old-school FIXME comment. (something searchable that something > needs done) […] I do understand XXX comments, I just do not want them in our code unless there really is something left to be fixed ;-) - so thanks for removing. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/687?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9a278374f492a538f0c174ced1746c3b1f82b8c9 Gerrit-Change-Number: 687 Gerrit-PatchSet: 6 Gerrit-Owner: kallisti5 <a...@terarocket.io> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: kallisti5 <a...@terarocket.io> Gerrit-Comment-Date: Thu, 28 Nov 2024 10:15:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Comment-In-Reply-To: kallisti5 <a...@terarocket.io> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
