Attention is currently required from: cron2, flichtenheld, plaisthos.

kallisti5 has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/687?usp=email )

Change subject: Haiku: Introduce basic platform / tun support
......................................................................


Patch Set 6:

(1 comment)

File src/openvpn/tun.c:

http://gerrit.openvpn.net/c/openvpn/+/687/comment/d9705ee7_b7044362 :
PS4, Line 1637:         /* XXX: Need to add ifconfig_remote_netmask since right 
now it is just NULL */
> this XXX line irks me. […]
It's a common old-school FIXME comment. (something searchable that something 
needs done)

https://stackoverflow.com/a/1452945

However, I do think the original reason for it being there no longer exists... 
Removed :-)



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/687?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9a278374f492a538f0c174ced1746c3b1f82b8c9
Gerrit-Change-Number: 687
Gerrit-PatchSet: 6
Gerrit-Owner: kallisti5 <a...@terarocket.io>
Gerrit-Reviewer: cron2 <g...@greenie.muc.de>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: cron2 <g...@greenie.muc.de>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Wed, 27 Nov 2024 12:53:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <g...@greenie.muc.de>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to