Attention is currently required from: flichtenheld, plaisthos, stipa.

mrbff has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/808?usp=email )

Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle 
PUSH UPDATE control messages to allow options updating at runtime.
......................................................................


Patch Set 5:

(2 comments)

File CMakeLists.txt:

http://gerrit.openvpn.net/c/openvpn/+/808/comment/d57bba5b_c9eabd40 :
PS4, Line 817:      src/openvpn/platform.c
> buffer.c and platform.c are always added by foreach loop above. So they are 
> redundant here.
Done


File src/openvpn/options.h:

http://gerrit.openvpn.net/c/openvpn/+/808/comment/17c2f5d7_5fb82784 :
PS4, Line 791: #define PUF_TYPE_UNDEF  0    /** undefined filter type */
> You didn't resolve the conflict correctly when rebasing. Please copy the new 
> code here.
you are right, sorry!



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a
Gerrit-Change-Number: 808
Gerrit-PatchSet: 5
Gerrit-Owner: mrbff <ma...@mandelbit.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-CC: stipa <lstipa...@gmail.com>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Thu, 28 Nov 2024 15:57:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to