Attention is currently required from: flichtenheld, mrbff, plaisthos.

stipa has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/808?usp=email )

Change subject: PUSH_UPDATE: Allow OpenVPN in client mode to receive and handle 
PUSH UPDATE control messages to allow options updating at runtime.
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

Patchset:

PS6:
I did a quick test and following doesn't work:

2024-11-29 11:11:30 us=656000 PUSH: Received control message: 
'PUSH_UPDATE,ifconfig 10.8.0.4 255.255.255.0'
2024-11-29 11:11:30 us=656000 No option found
2024-11-29 11:12:48 us=265000 Closing ovpn-dco interface
2024-11-29 11:12:48 us=265000 NETSH: C:\Windows\system32\netsh.exe interface 
ipv4 delete dns 20 all
2024-11-29 11:12:48 us=421000 NETSH: C:\Windows\system32\netsh.exe interface 
ipv4 delete address 20 10.8.0.2 store=active
2024-11-29 11:12:48 us=609000 SIGTERM[hard,] received, process exiting


File src/openvpn/push.c:

http://gerrit.openvpn.net/c/openvpn/+/808/comment/8d650f48_e00d63e5 :
PS6, Line 543:                     msg(M_WARN, "No option found");
This warning is a bit confusing.

2024-11-29 10:58:57 us=140000 PUSH: Received control message: 'PUSH_UPDATE,-dns'
2024-11-29 10:58:57 us=140000 No option found

It is unclear what exactly does it mean and what user/admin is supposed to do 
with it.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/808?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I6ecd4cb47571cc8c20e46de8595c742aeec6064a
Gerrit-Change-Number: 808
Gerrit-PatchSet: 6
Gerrit-Owner: mrbff <ma...@mandelbit.com>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: stipa <lstipa...@gmail.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: mrbff <ma...@mandelbit.com>
Gerrit-Comment-Date: Fri, 29 Nov 2024 10:39:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to