Attention is currently required from: d12fk, flichtenheld, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email )
Change subject: dns: support multiple domains without DHCP ...................................................................... Patch Set 2: (3 comments) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/824/comment/21f75f54_201cbbb0 : PS2, Line 1302: CloseServiceHandle(dnssvc); SAL: Warning C6387 'dnssvc' could be '0'. openvpn C:\Users\lev\Projects\openvpn-build\src\openvpn\src\openvpnserv\interactive.c 1302 same on the following line. Add a NULL check? http://gerrit.openvpn.net/c/openvpn/+/824/comment/d64294ff_24966968 : PS2, Line 1584: size = (wcslen(list) + 1) * sizeof(list[0]); I got a SAL warning: Warning C6053 The prior call to 'wcsncpy' might not zero-terminate string 'list'. openvpn C:\Users\lev\Projects\openvpn-build\src\openvpn\src\openvpnserv\interactive.c 1584 I think on line 1581 we have +1 to copy NULL terminator from domains, so this is not an issue? Should we also initialize list with {0} to make SAL happy? http://gerrit.openvpn.net/c/openvpn/+/824/comment/e58e3f80_84b5ad3c : PS2, Line 1648: RemoveDnsSearchDomains(HKEY key, PCWSTR domains) SAL warning: Warning C6262 Function uses '16432' bytes of stack. Consider moving some data to heap. openvpn C:\Users\lev\Projects\openvpn-build\src\openvpn\src\openvpnserv\interactive.c 1648 Is 4096 a random "large enough" value? Can we make it, say, 2048 to make SAL happy? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icaffbfa6b2e8efa2bd24a05537cb74b15f4fed96 Gerrit-Change-Number: 824 Gerrit-PatchSet: 2 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Mon, 09 Dec 2024 12:28:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
