Attention is currently required from: d12fk, plaisthos. stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email )
Change subject: dns: support multiple domains without DHCP ...................................................................... Patch Set 3: Code-Review-1 (2 comments) File src/openvpn/tun.c: http://gerrit.openvpn.net/c/openvpn/+/824/comment/0f9f3597_7d564171 : PS3, Line 232: strncpynt(dns.domains + dstlen, o->domain_search_list[i], srclen); Hm, this doesn't appear to work. PUSH: Received control message: 'PUSH_REPLY,dns search-domains lol1 lol2, In this case srclen is 4, but strncpynt copies first 3 chars and then adds \0. Shall we use just strncpy? File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/824/comment/2b842d94_2e39b8fd : PS3, Line 2302: break; extra "break" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icaffbfa6b2e8efa2bd24a05537cb74b15f4fed96 Gerrit-Change-Number: 824 Gerrit-PatchSet: 3 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Tue, 17 Dec 2024 10:10:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
