Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email )
Change subject: dns: support multiple domains without DHCP ...................................................................... Patch Set 3: (3 comments) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/824/comment/df2d8e6a_fc1974ba : PS2, Line 1302: CloseServiceHandle(dnssvc); > SAL: […] Done http://gerrit.openvpn.net/c/openvpn/+/824/comment/848dd16c_3cd12015 : PS2, Line 1584: size = (wcslen(list) + 1) * sizeof(list[0]); > I got a SAL warning: […] The actual check is in line 1572 where we make sure there is enough room in the buffer to append the domains including the NUL at the end (+2, one for the comma, the other one for \0) wcsncpy() pads the source string wit 0 if count is greater than the len of the source string, so domlen + 1 will do the trick. I think it is indeed a false positive and wonder what triggers it. Let's try to init list with zeros and if that defeats the diagnostic, good enough, but it is not necessary. http://gerrit.openvpn.net/c/openvpn/+/824/comment/ffa63cf0_730a2c02 : PS2, Line 1648: RemoveDnsSearchDomains(HKEY key, PCWSTR domains) > SAL warning: […] Yeah, let's go with 2k and see where we land. Usually this should not be an issue I think as there are normally not so many search domains set. There _is_ no correct value here, unless you re(allocate) from the heap to make sure the local maximum is handled. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icaffbfa6b2e8efa2bd24a05537cb74b15f4fed96 Gerrit-Change-Number: 824 Gerrit-PatchSet: 3 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Thu, 12 Dec 2024 07:51:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
