Attention is currently required from: flichtenheld, plaisthos, stipa. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email )
Change subject: dns: support multiple domains without DHCP ...................................................................... Patch Set 4: (5 comments) File src/openvpn/tun.c: http://gerrit.openvpn.net/c/openvpn/+/824/comment/44d589a3_55773eae : PS3, Line 232: strncpynt(dns.domains + dstlen, o->domain_search_list[i], srclen); > Hm, this doesn't appear to work. […] Yeah, in this case it's better since remaining buffer is checked before to fit the terminating zero. strcpy would work as well, but usually raises an eyebrow with tools. So, adding the missing srclen + 1 for strncpy for the actual fix. http://gerrit.openvpn.net/c/openvpn/+/824/comment/d469bffe_01c87c06 : PS3, Line 1745: /* Empty for _WIN32 and all other unixoid platforms */ > Spurious change that cause uncrustify errors Acknowledged http://gerrit.openvpn.net/c/openvpn/+/824/comment/64d0080e_818b319f : PS3, Line 1771: /* Empty for _WIN32 and all other unixoid platforms */ > Spurious change that causes uncrustify errors Acknowledged File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/824/comment/7cee0941_deaae7b2 : PS3, Line 1333: MsgToEventLog(M_ERR, L"InterfaceIdString: " > Why `L""` here and not `TEXT()`? TEXT() expands to L"" when UNICODE is defined, but will change for consistency anyway. There's another one at #766, but unrelated to this changeset. Will try to remember to ship a followup patch for this later. http://gerrit.openvpn.net/c/openvpn/+/824/comment/da696840_4fc75d6d : PS3, Line 2302: break; > extra "break" Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icaffbfa6b2e8efa2bd24a05537cb74b15f4fed96 Gerrit-Change-Number: 824 Gerrit-PatchSet: 4 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Sat, 21 Dec 2024 22:40:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
