Attention is currently required from: flichtenheld, plaisthos. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/806?usp=email )
Change subject: Implement epoch key data format ...................................................................... Patch Set 18: (3 comments) Patchset: PS18: Some minor comments. Also, I'll read the tests again later. I don't think I fully got them yet. File tests/unit_tests/openvpn/test_crypto.c: http://gerrit.openvpn.net/c/openvpn/+/806/comment/42fb5434_e8016878 : PS18, Line 877: * the end of array. Iterating through all 65k keys takes a 2-3s, so we Why is this number changed? File tests/unit_tests/openvpn/test_ssl.c: http://gerrit.openvpn.net/c/openvpn/+/806/comment/47bafe95_4b39c681 : PS18, Line 642: const uint8_t exp_tag_short[16] = What makes this short? It's exactly as long as the other. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/806?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I00751c42cb04e30205ba8e6584530831e0d143c5 Gerrit-Change-Number: 806 Gerrit-PatchSet: 18 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: MaxF <m...@max-fillinger.net> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 05 Feb 2025 17:01:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
