Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )
Change subject: dns: apply settings via script on unixoid systems ...................................................................... Patch Set 6: (2 comments) File distro/dns-scripts/systemd-dns-updown.sh: http://gerrit.openvpn.net/c/openvpn/+/838/comment/2f129ac9_1e6e34f1 : PS6, Line 15: # Example env from openvpn (not all are always applied): Example should mention dev, script-type, and dns-vars-file (comment applies to all variants of the script). http://gerrit.openvpn.net/c/openvpn/+/838/comment/68692646_1b746e29 : PS6, Line 30: [ -z "${dns_vars_file}" ] || . "${dns_vars_file}" dns_vars_file is not actually used until the next commit, should this line be moved to there? (comment applies to all variants of the script). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10 Gerrit-Change-Number: 838 Gerrit-PatchSet: 6 Gerrit-Owner: d12fk <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: d12fk <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2025 17:25:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
