Attention is currently required from: flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )
Change subject: dns: apply settings via script on unixoid systems ...................................................................... Patch Set 8: (5 comments) File distro/dns-scripts/systemd-dns-updown.sh: http://gerrit.openvpn.net/c/openvpn/+/838/comment/e7242d2e_9ce75db6 : PS7, Line 91: [[ "$(readlink /etc/resolv.conf)" =~ systemd ]] || return 1 > This fallback is nice, but I really would like to see some kind of message > about it in the log. Problem is that scripts can't log anything afaik. File src/openvpn/dns.c: http://gerrit.openvpn.net/c/openvpn/+/838/comment/431ae915_d56a1d76 : PS7, Line 545: int res = openvpn_run_script(&argv, es, S_FATAL|S_EXITCODE, "dns script"); > This actually lead to annoying problems in my testing. […] Acknowledged File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/838/comment/65694cc7_b840e8a4 : PS7, Line 911: o->dns_options.script = DNS_UPDOWN_PATH; > This does not work well as an unconditional default I think. […] Built-in script now runs as built-in and should not be complained about any longer. http://gerrit.openvpn.net/c/openvpn/+/838/comment/55e960a6_805f6e3f : PS7, Line 8045: else if (streq(p[0], "dns-script") && p[1]) > New script should be documented in `doc/man-sections/script-options. […] Actually missed pushing the doc commit the whole time, thanks for pointing it out. http://gerrit.openvpn.net/c/openvpn/+/838/comment/c7497690_9e53e4ce : PS7, Line 8052: set_user_script(options, &options->dns_options.script, p[1], p[0], false); > Again, this does not behave nice at all. […] Not sure if we need the possibility to disable --dns-script, as on Windows it is not possible either, but it is implemented now by --dns-script disable, with disable being a reserved "filename" for that purpose. Seemed reasonable. Also the built-in script requires script-security 1 now, 2 is only needed for user defined scripts, works as intended this way. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10 Gerrit-Change-Number: 838 Gerrit-PatchSet: 8 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 27 Feb 2025 00:29:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
