Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )
Change subject: dns: apply settings via script on unixoid systems ...................................................................... Patch Set 9: Code-Review-2 (8 comments) Patchset: PS9: You broke it File distro/dns-scripts/systemd-dns-updown.sh: http://gerrit.openvpn.net/c/openvpn/+/838/comment/57d1206f_56136b77 : PS7, Line 91: [[ "$(readlink /etc/resolv.conf)" =~ systemd ]] || return 1 > In that case, yeah. […] Done File distro/dns-scripts/systemd-dns-updown.sh: http://gerrit.openvpn.net/c/openvpn/+/838/comment/4b946c0f_aa2c619b : PS9, Line 75: "$ Maybe we could add a comment here like: "Add as a routing-only domain (~ prefix) unless already configured as a search domain". Sure, this is documented in systemd documentation, but unless you're intimately familiar with that this code just looks like gibberish. http://gerrit.openvpn.net/c/openvpn/+/838/comment/80d52a50_87e35eb1 : PS9, Line 75: =~ This broken now. If this matches it does continue but it does not increase "i" so it is an endless loop. http://gerrit.openvpn.net/c/openvpn/+/838/comment/1795ad88_bac2fb33 : PS9, Line 116: [ -n "${!transport_var}" -a "${!transport_var}" = "DoH" ] || break I think this line could use a comment like "skip DoH dns entries", otherwise it takes a while to understand what this does. File doc/man-sections/script-options.rst: http://gerrit.openvpn.net/c/openvpn/+/838/comment/ebb56b30_2366159f : PS9, Line 258: environment values will be passed to ``--up`` and ``--down`` if no ``--dns`` This sentence is too complicated. After reading it I'm now more confused than before how --dhcp-option and --dns interact. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/838/comment/39eeba0b_9ae2c8e3 : PS7, Line 8045: else if (streq(p[0], "dns-script") && p[1]) > Actually missed pushing the doc commit the whole time, thanks for pointing it > out. Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/838/comment/8ee3982a_93d7f782 : PS9, Line 531: "--dns-script cmd : Run cmd as user defined dns configuration script\n" Would change this to `--dns-script disable|cmd` -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10 Gerrit-Change-Number: 838 Gerrit-PatchSet: 9 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Wed, 05 Mar 2025 10:47:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: d12fk <he...@openvpn.net> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
