Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )
Change subject: dns: apply settings via script on unixoid systems ...................................................................... Patch Set 8: Code-Review-1 (4 comments) Patchset: PS8: Still discussing some of my earlier complaints, but overall the default behavior looks good to me now. File distro/dns-scripts/systemd-dns-updown.sh: http://gerrit.openvpn.net/c/openvpn/+/838/comment/c52dbf8e_3ccb81e6 : PS7, Line 91: [[ "$(readlink /etc/resolv.conf)" =~ systemd ]] || return 1 > Problem is that scripts can't log anything afaik. Not sure what you mean. You can just "echo" in scripts and the output will appear in the log. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/838/comment/7fd139cb_82dfc0a9 : PS7, Line 911: o->dns_options.script = DNS_UPDOWN_PATH; > Built-in script now runs as built-in and should not be complained about any > longer. Done http://gerrit.openvpn.net/c/openvpn/+/838/comment/79dede80_0f0470c1 : PS7, Line 8052: set_user_script(options, &options->dns_options.script, p[1], p[0], false); > Not sure if we need the possibility to disable --dns-script, as on Windows it > is not possible either […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10 Gerrit-Change-Number: 838 Gerrit-PatchSet: 8 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Mon, 03 Mar 2025 16:44:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: d12fk <he...@openvpn.net> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
