Attention is currently required from: d12fk, flichtenheld, plaisthos.

stipa has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/824?usp=email )

Change subject: dns: support multiple domains without DHCP
......................................................................


Patch Set 8:

(1 comment)

Patchset:

PS8:
Looks good and does what it says. I tested that pushed search domains are 
indeed applied and Windows uses them for DNS lookup and than existing search 
domains are preserved and restored after disconnect.

However this warning is still triggered for search-domains:

Mon Jan 20 13:52:28 2025 Some --dhcp-option or --dns options require DHCP 
server, which is not supported by the selected ovpn-dco driver. They will be 
ignored.

Let's get rid of it buy not setting the flag in tuntap_options_copy_dns(),



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: Icaffbfa6b2e8efa2bd24a05537cb74b15f4fed96
Gerrit-Change-Number: 824
Gerrit-PatchSet: 8
Gerrit-Owner: d12fk <he...@openvpn.net>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: stipa <lstipa...@gmail.com>
Gerrit-CC: cron2 <g...@greenie.muc.de>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: d12fk <he...@openvpn.net>
Gerrit-Comment-Date: Mon, 20 Jan 2025 11:54:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to