Attention is currently required from: d12fk, flichtenheld, plaisthos, stipa.
cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email ) Change subject: dns: support multiple domains without DHCP ...................................................................... Patch Set 13: Code-Review+2 (3 comments) Patchset: PS13: There's still a partly unresolved discussion and it needs to be tested what happens with multiple concurrent VPNs modifying the global search list - but for all normal cases this should work fine. I'm moving forward, and we can fix this particular corner case later if it turns out to be problematic. File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/824/comment/3d28cfaf_6da650d8 : PS12, Line 1631: goto out; > Yeah that is intentional. […] With the adjusted comment ("doesn't reset anything") the code now matches the comment, so fine with me :-) http://gerrit.openvpn.net/c/openvpn/+/824/comment/3e617702_23668b59 : PS12, Line 1698: } > When we get there something is inconsistent in the registry. […] Indeed, we should never end in this state at all - though I do wonder what happens if there are overlapping VPNs modifying the global search list (both adding to it, and then the first existing and resetting the `InitialSearchList`). Guess we'll find out when the first issue gets openened :-) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icaffbfa6b2e8efa2bd24a05537cb74b15f4fed96 Gerrit-Change-Number: 824 Gerrit-PatchSet: 13 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Wed, 12 Mar 2025 09:21:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Comment-In-Reply-To: d12fk <he...@openvpn.net> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
