Attention is currently required from: cron2, flichtenheld, plaisthos. d12fk has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email )
Change subject: dns: support multiple domains without DHCP ...................................................................... Patch Set 12: (7 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/824/comment/7e7bfac6_b367e51d : PS12, Line 23: > please reference the github issue about WMIC no longer working on Win11 […] Done File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/824/comment/70916549_d4e0161f : PS12, Line 1171: ApplyGpolSettings32() > `(void)` Done http://gerrit.openvpn.net/c/openvpn/+/824/comment/2b36d095_cbfd9faa : PS12, Line 1211: ApplyGpolSettings64() > `(void)` Done http://gerrit.openvpn.net/c/openvpn/+/824/comment/12b0644b_5e2f5cad : PS12, Line 1248: ApplyGpolSettings() > `(void)` Done http://gerrit.openvpn.net/c/openvpn/+/824/comment/2dd35100_49932acc : PS12, Line 1609: * If it doesn't exists, resets to empty, effectively disabling it. > typo here ("exists") Done http://gerrit.openvpn.net/c/openvpn/+/824/comment/ea2a7802_1d8a8a94 : PS12, Line 1631: goto out; > my understanding of the code flow is that the `goto out` should be inside the > `if (err != ERROR_FILE […] Yeah that is intentional. If there was no SearchList, there will be no IninitalSearchList created in the first place. http://gerrit.openvpn.net/c/openvpn/+/824/comment/6b364f9b_c7efb34c : PS12, Line 1698: } > in this case ("no InitialSearchList can be found") this whole function would > then fail to do anythin […] When we get there something is inconsistent in the registry. The SearchList is not empty, but we do not have a InitialSearchList to compare to. Storing the shorter, but non-empty list is as wrong as leaving it in its current state, as it is not empty, not can it be reset to the original list. If you rather have the `return` removed and the next branch turned into an `else if` I can do it, but the SearchList will still be in an undefined state after the modification. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icaffbfa6b2e8efa2bd24a05537cb74b15f4fed96 Gerrit-Change-Number: 824 Gerrit-PatchSet: 12 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 12 Mar 2025 04:05:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
