Attention is currently required from: d12fk, flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/824?usp=email )
Change subject: dns: support multiple domains without DHCP ...................................................................... Patch Set 12: Code-Review-1 (8 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/824/comment/0e9bde67_521ea38a : PS12, Line 23: please reference the github issue about WMIC no longer working on Win11 Github: OpenVPN/openvpn#642 Patchset: PS12: a couple of very minor nits, but there's one thing I consider important enough to clarify before applying. File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/824/comment/614ca4f1_082ef8e0 : PS12, Line 1171: ApplyGpolSettings32() `(void)` http://gerrit.openvpn.net/c/openvpn/+/824/comment/15f3c9b6_c46bf981 : PS12, Line 1211: ApplyGpolSettings64() `(void)` http://gerrit.openvpn.net/c/openvpn/+/824/comment/31278e47_77ce57be : PS12, Line 1248: ApplyGpolSettings() `(void)` http://gerrit.openvpn.net/c/openvpn/+/824/comment/17e52f07_1dd206a9 : PS12, Line 1609: * If it doesn't exists, resets to empty, effectively disabling it. typo here ("exists") http://gerrit.openvpn.net/c/openvpn/+/824/comment/94c13555_6c14a07a : PS12, Line 1631: goto out; my understanding of the code flow is that the `goto out` should be inside the `if (err != ERROR_FILE_NOT_FOUND)` because otherwise the described behaviour "if it doesn't exist = FILE NOT FOUND, reset to empty" can never be triggered. http://gerrit.openvpn.net/c/openvpn/+/824/comment/c8ba0a57_5dfb1b78 : PS12, Line 1698: } in this case ("no InitialSearchList can be found") this whole function would then fail to do anything, as RegSetValueExW() is skipped. Is this intentional? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/824?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Icaffbfa6b2e8efa2bd24a05537cb74b15f4fed96 Gerrit-Change-Number: 824 Gerrit-PatchSet: 12 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: stipa <lstipa...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Sun, 09 Mar 2025 15:21:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
