Attention is currently required from: MaxF, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/806?usp=email )
Change subject: Implement epoch key data format ...................................................................... Patch Set 18: (2 comments) File tests/unit_tests/openvpn/test_crypto.c: http://gerrit.openvpn.net/c/openvpn/+/806/comment/2fea2111_397e3eef : PS18, Line 877: * the end of array. Iterating through all 65k keys takes a 2-3s, so we > Why is this number changed? Because I am stupid and thought that for some reason that maximum epoch of 16bit is 16k when it is actually 65k. The unit tests still works because it just iterated through all the remaining 48k keys but it didn't avoid the 2-3 delay .... File tests/unit_tests/openvpn/test_ssl.c: http://gerrit.openvpn.net/c/openvpn/+/806/comment/854f6f60_4167ef0b : PS18, Line 642: const uint8_t exp_tag_short[16] = > What makes this short? It's exactly as long as the other. tag for the short packet id. The name could have been chosen a bit better. It is still a leftover when there was a short and long packet id instead of a short packet id vs epoch packet id. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/806?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I00751c42cb04e30205ba8e6584530831e0d143c5 Gerrit-Change-Number: 806 Gerrit-PatchSet: 18 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: MaxF <m...@max-fillinger.net> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: MaxF <m...@max-fillinger.net> Gerrit-Comment-Date: Wed, 05 Feb 2025 17:07:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: MaxF <m...@max-fillinger.net> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
