Attention is currently required from: flichtenheld, plaisthos.

MaxF has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/806?usp=email )

Change subject: Implement epoch key data format
......................................................................


Patch Set 19: Code-Review+2

(2 comments)

File tests/unit_tests/openvpn/test_crypto.c:

http://gerrit.openvpn.net/c/openvpn/+/806/comment/b2f3e131_4cc9910e :
PS18, Line 877:      * the end of array. Iterating through all 65k keys takes a 
2-3s, so we
> Because I am stupid and thought that for some reason that maximum epoch of 
> 16bit is 16k when it is a […]
Done


File tests/unit_tests/openvpn/test_ssl.c:

http://gerrit.openvpn.net/c/openvpn/+/806/comment/501376f6_d5a27e2a :
PS18, Line 642:         const uint8_t exp_tag_short[16] =
> tag for the short packet id. The name could have been chosen a bit better. […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/806?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I00751c42cb04e30205ba8e6584530831e0d143c5
Gerrit-Change-Number: 806
Gerrit-PatchSet: 19
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: MaxF <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Wed, 12 Feb 2025 16:11:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: plaisthos <[email protected]>
Comment-In-Reply-To: MaxF <[email protected]>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to