Attention is currently required from: flichtenheld, mrbff, plaisthos. ordex has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email )
Change subject: PUSH_UPDATE server: check IV_PROTO before sending the message to the client ...................................................................... Patch Set 1: Code-Review-2 (3 comments) File src/openvpn/push_util.c: http://gerrit.openvpn.net/c/openvpn/+/1255/comment/af9bdc8d_7673d872?usp=email : PS1, Line 204: msg(M_CLIENT, "ERROR: Peer ID: %u does not support push-update", I'd remove the "ERROR:" label - this is just an information that we have unsupported clients connected and they won't receive the message. maybe something: "PUSH_UPDATE: not sending message to unsupported peer with ID %u"? http://gerrit.openvpn.net/c/openvpn/+/1255/comment/352256e9_45e6f7bc?usp=email : PS1, Line 205: mi->context.c2.tls_multi ? mi->context.c2.tls_multi->peer_id : UINT32_MAX); you just dereferenced "tls_multi" a few lines above, therefore it must be non-NULL at this point. If you believe it can be NULL, this check should happen earlier on. But can it really happen? I am not sure. http://gerrit.openvpn.net/c/openvpn/+/1255/comment/ac206d3c_e8cbc84e?usp=email : PS1, Line 252: gc_free(&gc); am I wrong or this is totally unrelated? It still seems a valid fix, but please submit it in its own patch. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7c28da72be11c7efbed3068fbfc65f2959227bec Gerrit-Change-Number: 1255 Gerrit-PatchSet: 1 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: mrbff <[email protected]> Gerrit-Comment-Date: Wed, 08 Oct 2025 12:03:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
