Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.
mrbff has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email ) Change subject: PUSH_UPDATE server: check IV_PROTO before sending the message to the client ...................................................................... Patch Set 1: (4 comments) File src/openvpn/push_util.c: http://gerrit.openvpn.net/c/openvpn/+/1255/comment/df855855_fc7dc98e?usp=email : PS1, Line 199: } > this cannot be NULL - but if you doubt your own callers, make it in an > `ASSERT(mi)`. Acknowledged http://gerrit.openvpn.net/c/openvpn/+/1255/comment/d70a48ea_ca9f747a?usp=email : PS1, Line 204: msg(M_CLIENT, "ERROR: Peer ID: %u does not support push-update", > For the "I want *this* one client" case, an ERROR is valid, for the "send to > all" it's a bit excessi […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/1255/comment/275c68b2_08325ea1?usp=email : PS1, Line 205: mi->context.c2.tls_multi ? mi->context.c2.tls_multi->peer_id : UINT32_MAX); > you just dereferenced "tls_multi" a few lines above, therefore it must be > non-NULL at this point. […] Acknowledged http://gerrit.openvpn.net/c/openvpn/+/1255/comment/b80626a7_60d0008d?usp=email : PS1, Line 252: gc_free(&gc); > am I wrong or this is totally unrelated? […] yeah, it is unrelated, but a patch only for this? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7c28da72be11c7efbed3068fbfc65f2959227bec Gerrit-Change-Number: 1255 Gerrit-PatchSet: 1 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: cron2 <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: cron2 <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: ordex <[email protected]> Gerrit-Comment-Date: Wed, 08 Oct 2025 12:19:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <[email protected]> Comment-In-Reply-To: ordex <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
