Attention is currently required from: cron2, flichtenheld, ordex, plaisthos.

mrbff has posted comments on this change by mrbff. ( 
http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email )

Change subject: PUSH_UPDATE server: check IV_PROTO before sending the message 
to the client
......................................................................


Patch Set 1:

(2 comments)

File src/openvpn/push_util.c:

http://gerrit.openvpn.net/c/openvpn/+/1255/comment/8cf8fa77_19df11d9?usp=email :
PS1, Line 204:         msg(M_CLIENT, "ERROR: Peer ID: %u does not support 
push-update",
> Acknowledged
Now i log the message "PUSH_UPDATE: not sending message to unsupported peer 
with ID %u" just in upt-cid. After that a "ERROR: no client updated" message 
will be logged so should be clear it's an error anyway.


http://gerrit.openvpn.net/c/openvpn/+/1255/comment/cbf60c60_b11a51e8?usp=email :
PS1, Line 252:             gc_free(&gc);
> I'l leave it in, and mention it in the commit message […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I7c28da72be11c7efbed3068fbfc65f2959227bec
Gerrit-Change-Number: 1255
Gerrit-PatchSet: 1
Gerrit-Owner: mrbff <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: ordex <[email protected]>
Gerrit-Reviewer: plaisthos <[email protected]>
Gerrit-CC: cron2 <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Attention: ordex <[email protected]>
Gerrit-Comment-Date: Wed, 08 Oct 2025 13:32:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: cron2 <[email protected]>
Comment-In-Reply-To: ordex <[email protected]>
Comment-In-Reply-To: mrbff <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to