Attention is currently required from: flichtenheld, mrbff, plaisthos. cron2 has posted comments on this change by mrbff. ( http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email )
Change subject: PUSH_UPDATE server: check IV_PROTO before sending the message to the client ...................................................................... Patch Set 1: (2 comments) File src/openvpn/push_util.c: http://gerrit.openvpn.net/c/openvpn/+/1255/comment/c4b5cab5_f39d3a8a?usp=email : PS1, Line 199: } this cannot be NULL - but if you doubt your own callers, make it in an `ASSERT(mi)`. http://gerrit.openvpn.net/c/openvpn/+/1255/comment/df6efcad_2cdada10?usp=email : PS1, Line 204: msg(M_CLIENT, "ERROR: Peer ID: %u does not support push-update", > I'd remove the "ERROR:" label - this is just an information that we have > unsupported clients connect […] For the "I want *this* one client" case, an ERROR is valid, for the "send to all" it's a bit excessive ("there are 400 clients connected, only 2 of them are new enough to receive this, so 398 error messages"). So maybe moving the `msg()` call to `UPD_BY_CID` case in send_push_update()? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1255?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I7c28da72be11c7efbed3068fbfc65f2959227bec Gerrit-Change-Number: 1255 Gerrit-PatchSet: 1 Gerrit-Owner: mrbff <[email protected]> Gerrit-Reviewer: flichtenheld <[email protected]> Gerrit-Reviewer: ordex <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-CC: cron2 <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Attention: flichtenheld <[email protected]> Gerrit-Attention: mrbff <[email protected]> Gerrit-Comment-Date: Wed, 08 Oct 2025 12:10:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ordex <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
