Attention is currently required from: Arne Schwabe, Frank Lichtenheld. Răzvan Cojocaru has posted comments on this change by Arne Schwabe. ( https://gerrit.openvpn.net/c/openvpn/+/2130?usp=email )
Change subject: Adjust ACC_MAX_MSG_LEN, fix ACC in p2p mode and improve documentation ...................................................................... Patch Set 4: Code-Review-1 (2 comments) File src/openvpn/acc.h: https://gerrit.openvpn.net/c/openvpn/+/2130/comment/8caf0242_92628aaa?usp=email : PS4, Line 34: #define ACC_MAX_MSG_LEN (TLS_CHANNEL_BUF_SIZE - 128) `log_acc_message()` sends messages through `msg()` which formats them into buffers of `ERR_BUF_SIZE` which is currently `1280`. `ACC_MAX_MSG_LEN` is now `1920` so bigger than what can be delivered. Not sure if we want to fix that. File src/openvpn/ssl.c: https://gerrit.openvpn.net/c/openvpn/+/2130/comment/0478a2e2_94f4f011?usp=email : PS4, Line 2403: notify_client_acc_protocols(multi); This seems to be sent out regardless of whether negotiation worked or not. Would it be acceptable to send it in `determine_common_acc_protocols()` after `after acc_negotiated_protocols` is set, when `when multi->opt.mode != MODE_SERVER`? -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3a268fc602e916bf54853c950761977cf3d7f835 Gerrit-Change-Number: 2130 Gerrit-PatchSet: 4 Gerrit-Owner: Arne Schwabe <[email protected]> Gerrit-Reviewer: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Thu, 05 Nov 2026 16:45:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
