Attention is currently required from: Frank Lichtenheld, Răzvan Cojocaru. Arne Schwabe has posted comments on this change by Arne Schwabe. ( https://gerrit.openvpn.net/c/openvpn/+/2130?usp=email )
Change subject: Adjust ACC_MAX_MSG_LEN, fix ACC in p2p mode and improve documentation ...................................................................... Patch Set 2: (5 comments) File doc/management-notes.txt: https://gerrit.openvpn.net/c/openvpn/+/2130/comment/a19e30c2_69218d04?usp=email : PS1, Line 1402: over ACC to indicate if multiple ACC message should be considered to > Typo: "multiple ACC messages". Done https://gerrit.openvpn.net/c/openvpn/+/2130/comment/b73e4230_fc7b832e?usp=email : PS1, Line 1409: Overlong message are considered invalid and indicate that the peer is > Typo: "messages are". Done File src/openvpn/acc.h: https://gerrit.openvpn.net/c/openvpn/+/2130/comment/5d6e8f38_20e1c944?usp=email : PS1, Line 33: * is much closer to the TLS_CHANNEL_BUF_SIZE (2048) */ > Do we want to specify the current size of `TLS_CHANNEL_BUF_SIZE`? This > comment could go stale if tha […] Done File src/openvpn/acc.c: https://gerrit.openvpn.net/c/openvpn/+/2130/comment/12dd80eb_41ce3fb8?usp=email : PS1, Line 195: * that restrict the message size like TLS_CHANNEL_BUF_SIZE (2048). > Here too, not sure if we want to risk the comment going stale about the size > of `TLS_CHANNEL_BUF_SIZ […] Done File tests/unit_tests/openvpn/test_acc.c: https://gerrit.openvpn.net/c/openvpn/+/2130/comment/74bb1b1e_25d0af58?usp=email : PS1, Line 184: assert_int_equal(max_len, 2048 - 128); > Why not use ACC_MAX_MSG_LEN here? Done -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3a268fc602e916bf54853c950761977cf3d7f835 Gerrit-Change-Number: 2130 Gerrit-PatchSet: 2 Gerrit-Owner: Arne Schwabe <[email protected]> Gerrit-Reviewer: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Wed, 04 Nov 2026 22:53:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Răzvan Cojocaru <[email protected]> Comment-In-Reply-To: Frank Lichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
