Attention is currently required from: Frank Lichtenheld, Răzvan Cojocaru. Arne Schwabe has posted comments on this change by Arne Schwabe. ( https://gerrit.openvpn.net/c/openvpn/+/2130?usp=email )
Change subject: Adjust ACC_MAX_MSG_LEN, fix ACC in p2p mode and improve documentation ...................................................................... Patch Set 4: (2 comments) File src/openvpn/acc.h: https://gerrit.openvpn.net/c/openvpn/+/2130/comment/3f650cc5_e0594e8b?usp=email : PS4, Line 34: #define ACC_MAX_MSG_LEN (TLS_CHANNEL_BUF_SIZE - 128) > `log_acc_message()` sends messages through `msg()` which formats them into > buffers of `ERR_BUF_SIZE` […] I don't think that is correct. The only part in this function that logs the payload itself is inside `#ifdef ENABLE_MANAGEMENT` and if that is enabled the ERR_BUF_SIZE is 10240: #if defined(ENABLE_PKCS11) || defined(ENABLE_MANAGEMENT) #define ERR_BUF_SIZE 10240 #else #define ERR_BUF_SIZE 1280 #endif File src/openvpn/ssl.c: https://gerrit.openvpn.net/c/openvpn/+/2130/comment/7e0a3db1_515763c7?usp=email : PS4, Line 2403: notify_client_acc_protocols(multi); > This seems to be sent out regardless of whether negotiation worked or not. […] Done -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2130?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3a268fc602e916bf54853c950761977cf3d7f835 Gerrit-Change-Number: 2130 Gerrit-PatchSet: 4 Gerrit-Owner: Arne Schwabe <[email protected]> Gerrit-Reviewer: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Fri, 06 Nov 2026 11:27:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Răzvan Cojocaru <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
