Attention is currently required from: Arne Schwabe, Frank Lichtenheld.

Răzvan Cojocaru has posted comments on this change by Arne Schwabe. ( 
https://gerrit.openvpn.net/c/openvpn/+/2130?usp=email )

Change subject: Adjust ACC_MAX_MSG_LEN, fix ACC in p2p mode and improve 
documentation
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

Patchset:

PS3:
test_acc.c:187 fails:

```
[ RUN      ] test_parse_acc_parameters
[  ERROR   ] --- 1920 != 2048
[   LINE   ] --- test_acc.c:187: error: Failure!
```


Commit Message:

https://gerrit.openvpn.net/c/openvpn/+/2130/comment/841bf794_c6ef5615?usp=email 
:
PS3, Line 12: Fix that the management notification about negotiated protocol is 
not send
Typo: "is not sent".



--
To view, visit https://gerrit.openvpn.net/c/openvpn/+/2130?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I3a268fc602e916bf54853c950761977cf3d7f835
Gerrit-Change-Number: 2130
Gerrit-PatchSet: 3
Gerrit-Owner: Arne Schwabe <[email protected]>
Gerrit-Reviewer: Frank Lichtenheld <[email protected]>
Gerrit-Reviewer: Răzvan Cojocaru <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: Arne Schwabe <[email protected]>
Gerrit-Attention: Frank Lichtenheld <[email protected]>
Gerrit-Comment-Date: Thu, 05 Nov 2026 05:48:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to