Attention is currently required from: Arne Schwabe, Frank Lichtenheld. Răzvan Cojocaru has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/2158?usp=email )
Change subject: crypto*: Avoid sign conversion warnings by using defines directly ...................................................................... Patch Set 2: Code-Review-1 (2 comments) Commit Message: https://gerrit.openvpn.net/c/openvpn/+/2158/comment/fbe7339f_12d826a8?usp=email : PS2, Line 13: I do not think that using an intermediate variabl Typo: "variable". File src/openvpn/crypto.c: https://gerrit.openvpn.net/c/openvpn/+/2158/comment/e3080b51_2cd0ffb9?usp=email : PS2, Line 539: const uintptr_t ad_size = (uintptr_t)(BPTR(buf) - ad_start); `uintptr_t` doesn't sound like the right type to use here. My man page says: "integer types wide enough to hold pointers", but that's not what it is used for here. `size_t` would probably make more sense. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5 Gerrit-Change-Number: 2158 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 10 Nov 2026 11:48:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
