Attention is currently required from: Arne Schwabe, Frank Lichtenheld. Răzvan Cojocaru has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/2158?usp=email )
Change subject: crypto*: Avoid sign conversion warnings by using defines directly ...................................................................... Patch Set 4: Code-Review-1 (3 comments) Patchset: PS4: Changing `packet_id_size()` and `tls_crypt_buf_overhead()` to `unsigned int` adds warnings in callers that still use `int`: - init.c:3150 (`int required_size = 5 + wkc_len + tls_crypt_buf_overhead() + ...)` - ssl.c:170 (`max_int(tls_crypt_buf_overhead(), packet_id_size(true) + ...)`, both arguments) - ssl_pkt.c:70 (`const int hmac_size = hmac_ctx_size(...) + packet_id_size(true)`) That may be intended, just making a note. File src/openvpn/crypto_epoch.c: https://gerrit.openvpn.net/c/openvpn/+/2158/comment/d6f0f0ec_1e2e0a38?usp=email : PS4, Line 44: #endif I think this pragma can no go away as well. https://gerrit.openvpn.net/c/openvpn/+/2158/comment/4ee2f0d2_98829d0d?usp=email : PS4, Line 466: #endif This `pop` can now go away as well. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5 Gerrit-Change-Number: 2158 Gerrit-PatchSet: 4 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 10 Nov 2026 14:33:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
