Attention is currently required from: Arne Schwabe, Răzvan Cojocaru. Frank Lichtenheld has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/2158?usp=email )
Change subject: crypto*: Avoid sign conversion warnings by using defines directly ...................................................................... Patch Set 2: (1 comment) File src/openvpn/crypto.c: https://gerrit.openvpn.net/c/openvpn/+/2158/comment/e8d213cc_27297988?usp=email : PS2, Line 539: const uintptr_t ad_size = (uintptr_t)(BPTR(buf) - ad_start); > `uintptr_t` doesn't sound like the right type to use here. […] But it is a difference between two pointers, so it feels appropriate to me? -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5 Gerrit-Change-Number: 2158 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Răzvan Cojocaru <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Comment-Date: Tue, 10 Nov 2026 12:14:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Răzvan Cojocaru <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
