Attention is currently required from: Arne Schwabe, Frank Lichtenheld. Răzvan Cojocaru has posted comments on this change by Frank Lichtenheld. ( https://gerrit.openvpn.net/c/openvpn/+/2158?usp=email )
Change subject: crypto*: Avoid sign conversion warnings by using defines directly ...................................................................... Patch Set 2: (1 comment) File src/openvpn/crypto.c: https://gerrit.openvpn.net/c/openvpn/+/2158/comment/45fbdef0_3eaac5d1?usp=email : PS2, Line 539: const uintptr_t ad_size = (uintptr_t)(BPTR(buf) - ad_start); > But it is a difference between two pointers, so it feels appropriate to me? You might be thinking of `ptrdiff_t`? Which I agree would be better than `uintptr_t`, but it's a signed type, which makes `size_t` better considering where it is being subsequently used. -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/2158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I3bcb4cb8e17ff80a5cb8acdaf18d1072159184e5 Gerrit-Change-Number: 2158 Gerrit-PatchSet: 2 Gerrit-Owner: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Arne Schwabe <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: Arne Schwabe <[email protected]> Gerrit-Attention: Frank Lichtenheld <[email protected]> Gerrit-Comment-Date: Tue, 10 Nov 2026 12:17:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Răzvan Cojocaru <[email protected]> Comment-In-Reply-To: Frank Lichtenheld <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
