Txs Kevan! I have an active CLA signed for a few maven, scm and openjpa contributions I did, so all rights should be granted already. But I apologize to use Jira in the future for better tracking ;)
Btw, I now at least know partially why the tests fail on my computer. The ClassUtil#isValueOkForDate(String value) uses DateFormat.getDateTimeInstance().parse(value); which is depending on the actual Locale, and the ParseException is catched away null is returned instead. Do we really need to be that lenient? Or should we better not catch the Exception? If so we would get the java.text.ParseException: Unparseable date: "September 30, 1998 10:45:30 PM CST" This leads us further to the fundamental question about which Locale and timezone to use for dates, etc? The WebBeans-1.0_pr-spec section 9.2.5 doesn't mention this yet (e.g. SOAP spec does, which is a big bonus there). Do you think this should be implementation specific, or should we ask Gavin to clarify this point in the spec? LieGrue, strub ---------------------------------------------------------------- “Multiple exclamation marks are a sure sign of a diseased mind!” (Sir Terry Pratchett) --- Kevan Miller <[email protected]> schrieb am Di, 6.1.2009: > Von: Kevan Miller <[email protected]> > Betreff: Re: [PATCH] fix for navigation rules in sample 'guess' > An: [email protected] > Datum: Dienstag, 6. Januar 2009, 15:33 > On Jan 5, 2009, at 10:50 AM, Mohammad Nour El-Din wrote: > > > Hi Mark... > > > > For the JIRA part I think it is better to create a > JIRA and attach > > your patches on for better recording and tracking. I > will let the > > other part of the question for Gurkan to answer as I > am not so aware > > of the status of the sample application. > > Patch files should almost always be submitted via Jira > "Attach File". The important reason for this is > the "Grant license to ASF" button on the attach > file page. This button gives the ASF clear rights to license > the submission under the Apache License. For such a trivial > fix as adding '/' character, this isn't really > needed, but for anything more complex, it's definitely > the way to go. > > Also, please note that when you commit a patch that someone > has submitted, you should give attribution in the commit > message. Something like: > > svn ci --message "OWB-34 Patch from Mark Struberg. Fix > path to faces-config files. Thanks Mark!" > > --kevan
