Hi Mark, Please patch your changes into the code, attach this as the JIRA issue , I will definitely look for it and commit;
There is a IRC in FreeNode with name #openwebbeans /Gurkan ________________________________ From: Mark Struberg <[email protected]> To: [email protected] Sent: Tuesday, January 6, 2009 9:58:12 PM Subject: Re: [PATCH] fix for navigation rules in sample 'guess' Hi Gurkan! > Actually DateFormat.getDateTimeInstance() returns according > to the current locale, so it is fine. It may not necessary > to ask for this. I thought of the following problem I've had at my daily work: I do development and installation of a WAR which gets installed in a few NOCs around the globe. So if I use the web-beans.xml to set a default for a beans date field, this setting has to be independent of the Locale the server is actually running. Btw: This is also true for our test cases which should run in all countries (myapp:dateField in fieldText.xml is broken for Austrian Locale). For this cases a fixed DateFormat would work better than DateFormat.getDateTimeInstance() Maybe: DateFormat.getDateTimeInstance(DateFormat.DEFAULT, DateFormat.DEFAULT, Locale.US).parse(value); ? Not that I like the US DateFormat most, we could also use another fixed one. We also could use the standard SOAP format if you like. LieGrue, strub P.S.: Is the IRC already setup and being used? --- Gurkan Erdogdu <[email protected]> schrieb am Di, 6.1.2009: > Von: Gurkan Erdogdu <[email protected]> > Betreff: Re: [PATCH] fix for navigation rules in sample 'guess' > An: [email protected] > Datum: Dienstag, 6. Januar 2009, 16:44 > Actually DateFormat.getDateTimeInstance() returns according > to the current locale, so it is fine. It may not necessary > to ask for this. > Yeap you are right, we may not catch the exception and > return null, instead throws Parse Exception seems more > reasonable than return null. > > /Gurkan > > > > > ________________________________ > From: Mark Struberg <[email protected]> > To: [email protected] > Sent: Tuesday, January 6, 2009 5:00:26 PM > Subject: Re: [PATCH] fix for navigation rules in sample > 'guess' > > Txs Kevan! > > I have an active CLA signed for a few maven, scm and > openjpa contributions I did, so all rights should be granted > already. But I apologize to use Jira in the future for > better tracking ;) > > Btw, I now at least know partially why the tests fail on my > computer. > > The > ClassUtil#isValueOkForDate(String value) > uses > DateFormat.getDateTimeInstance().parse(value); > which is depending on the actual Locale, and the > ParseException is catched away null is returned instead. Do > we really need to be that lenient? Or should we better not > catch the Exception? If so we would get the > java.text.ParseException: Unparseable date: "September > 30, 1998 10:45:30 PM CST" > > This leads us further to the fundamental question about > which Locale and timezone to use for dates, etc? The > WebBeans-1.0_pr-spec section 9.2.5 doesn't mention this > yet (e.g. SOAP spec does, which is a big bonus there). Do > you think this should be implementation specific, or should > we ask Gavin to clarify this point in the spec? > > LieGrue, > strub > ---------------------------------------------------------------- > “Multiple exclamation marks are a sure sign of a diseased > mind!” > (Sir Terry Pratchett) > > > --- Kevan Miller <[email protected]> schrieb am > Di, 6.1.2009: > > > Von: Kevan Miller <[email protected]> > > Betreff: Re: [PATCH] fix for navigation rules in > sample 'guess' > > An: [email protected] > > Datum: Dienstag, 6. Januar 2009, 15:33 > > On Jan 5, 2009, at 10:50 AM, Mohammad Nour El-Din > wrote: > > > > > Hi Mark... > > > > > > For the JIRA part I think it is better to create > a > > JIRA and attach > > > your patches on for better recording and > tracking. I > > will let the > > > other part of the question for Gurkan to answer > as I > > am not so aware > > > of the status of the sample application. > > > > Patch files should almost always be submitted via Jira > > "Attach File". The important reason for this > is > > the "Grant license to ASF" button on the > attach > > file page. This button gives the ASF clear rights to > license > > the submission under the Apache License. For such a > trivial > > fix as adding '/' character, this isn't > really > > needed, but for anything more complex, it's > definitely > > the way to go. > > > > Also, please note that when you commit a patch that > someone > > has submitted, you should give attribution in the > commit > > message. Something like: > > > > svn ci --message "OWB-34 Patch from Mark > Struberg. Fix > > path to faces-config files. Thanks Mark!" > > > > --kevan
