10/12/2018 23:46, Petr Štetiar:
Currently there is no LED signalization for various system states
implemented in diag.sh, so this patch adds support for it.

Tested-by: Joe Ayers <[email protected]>
Signed-off-by: Petr Štetiar <[email protected]>
---
  target/linux/ath79/dts/ar9342_ubnt_xw.dtsi | 13 ++++++++++---
  1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/target/linux/ath79/dts/ar9342_ubnt_xw.dtsi 
b/target/linux/ath79/dts/ar9342_ubnt_xw.dtsi
index b104bc6..742df11 100644
--- a/target/linux/ath79/dts/ar9342_ubnt_xw.dtsi
+++ b/target/linux/ath79/dts/ar9342_ubnt_xw.dtsi
@@ -9,15 +9,22 @@
        compatible = "ubnt,xw", "qca,ar9342";
        model = "Ubiquiti Networks XW board";
+ aliases {
+               led-boot = &boot;
+               led-failsafe = &failsafe;
+               led-running = &boot;
+               led-upgrade = &upgrade;
+       };
+
        gpio-leds {
                compatible = "gpio-leds";
- link1 {
+               upgrade: link1 {
                        label = "ubnt:red:link1";
                        gpios = <&gpio 11 GPIO_ACTIVE_LOW>;
                };
- link2 {
+               failsafe: link2 {
                        label = "ubnt:orange:link2";
                        gpios = <&gpio 16 GPIO_ACTIVE_LOW>;
                };
@@ -27,7 +34,7 @@
                        gpios = <&gpio 13 GPIO_ACTIVE_LOW>;
                };
- link4 {
+               boot: link4 {
                        label = "ubnt:green:link4";
                        gpios = <&gpio 14 GPIO_ACTIVE_LOW>;
                };


Aren't these LEDs some kind of singal strength indicator? If so, they shouldn't be used to indicate a running system. I'm fine to temporary hijack the LEDs to indicate boot, failsafe and upgrade. But better use the same LED for all of these (link1)?

Mathias

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to