Mathias Kresin <[email protected]> [2018-12-12 13:27:17]:
Hi Mathias,
> > phy-mask = <4>;
> > +
> > phy4: ethernet-phy@4 {
> > - phy-mode = "rgmii";
> > reg = <4>;
> > + phy-mode = "rgmii";
> > };
> > };
>
> Unrelated noop change. Please drop it.
Ok.
> > ð0 {
> > status = "okay";
> > - pll-data = <0x06000000 0x00000101 0x00001313>;
>
> You drop the pll-data without adding them to the dtsi. This looks wrong and
> doesn't match the "move from dts to dtsi" from the commit message.
Yes, my bad, sorry. I've removed the pll-data since those defined in
ar934x.dtsi work and matches what is in ar71xx.
> > +++ b/target/linux/ath79/dts/ar9342_ubnt_xw.dtsi
> > @@ -117,3 +117,11 @@
> > mtd-cal-data = <&eeprom 0x1000>;
> > mtd-mac-address = <&eeprom 0x1002>;
> > };
> > +
> > +&mdio1 {
> > + status = "disabled";
> > +};
>
> This one is new and therefore doesn't match what is described in the commit
> message.
Ok, I'll make it clear.
Thanks for the review!
-- ynezz
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
