On 07/10/13 11:01, Alf Birger Rustad wrote:

>I am certainly open to the possibility that opm-parser should be part of opm-core.

To me it seems natural that parsing input files belongs to the core library. I can see that keeping opm-parser and opm-core as separate repositories long term can be convenient from a maintainer perspective, but I have a hard time seeing that it can be beneficial from any other perspective. Please enlighten me if there are important aspects here that I don't see.


ie, the only aspect that matters? user issues are solved through other means, buildsystems are there for developers and should be optimized for developer convenience. the more you can split, the less bug prone the development get in my experience (though setting up a build tree is slightly harder).

furthermore, opm-core is already bloated with tons of stuff that for my eyes do not appear to belong there (linear solvers, model parsing, a strategy for dog walks, etc). some of the stuff is misplaced there to the extent that is has been duped where it is more natural to put it (linear solver interfaces are duplicated in porsol).

imnsho*, the core library should just be a set of core utilities which are shared between modules, not a dump to avoid having to deal with more modules. parser should use core. core should not use parser. there is absolutely no requirement to use .grdecl files to use the rest of opm. why should it then sit in the core?

* -  http://www.urbandictionary.com/define.php?term=IMNSHO

arnem
_______________________________________________
Opm mailing list
[email protected]
http://www.opm-project.org/mailman/listinfo/opm

Reply via email to