Sounds to me like a good approach short term. Cheers, Alf
-----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Atgeirr Rasmussen Sent: 7. oktober 2013 12:34 To: OPM Mailing List Subject: Re: [OPM] OPM eclipse parser, status and plans Dear everyone, I have the following concrete suggestion for the development phase of opm-parser: 1. During development, opm-parser will depend on opm-core (possible also opm-autodiff, see point 4). 2. The classes in opm-core that now use the EclipseGridParser class will remain there, using that class. Example: IncompPropertiesFromDeck, GridManager. 3. New classes using the same abstract interfaces (IncompPropertiesInterface for example) are created to test opm-parser, instead of modifying the existing classes. These reside in opm-parser during the development period. 4. Simulator classes and programs that need modification to allow using the new classes are copied to opm-parser and modified there. Example: opm-core's sim_2p_incomp or opm-autodiff's sim_fibo_ad. Alternatively, we create abstract interfaces where we can, allowing polymorphism in more places (better, but more work). I think this will allow the best balance for the development period, not disturbing any other work, yet being able to integrate with it easily. It could also trigger healthy refactoring of existing software. Eventually, development reaches a level of maturity where we may merge opm-parser into opm-core or take other appropriate action. That can be discussed later. Atgeirr _______________________________________________ Opm mailing list [email protected] http://www.opm-project.org/mailman/listinfo/opm ------------------------------------------------------------------- The information contained in this message may be CONFIDENTIAL and is intended for the addressee only. Any unauthorised use, dissemination of the information or copying of this message is prohibited. If you are not the addressee, please notify the sender immediately by return e-mail and delete this message. Thank you _______________________________________________ Opm mailing list [email protected] http://www.opm-project.org/mailman/listinfo/opm
