Another git-related build issue.

commit c4e08e278bfaccc4c427f164c34fa32e07d24c76
Author: Martin Nolte <[email protected]>
Date:   Fri Aug 24 07:04:50 2012 +0000

    more parallel headers into subdirectory parallel (see FS#1055)

    [[Imported from SVN: r6925]]

This patch in DUNE moves several headers from dune/common to dune/common/parallel. This was fixed in opm right away, see this patch in

commit a41a01f5e13744faf46cfdbaef97cbb259d47a89
Author: Arne Morten Kvarving <[email protected]>
Date:   Fri Jun 13 11:55:42 2014 +0200

    fixed: building with dune > 2.3

    these symbols were deprecated in 2.3 and removed in master

+#if DUNE_VERSION_NEWER(DUNE_COMMON, 3, 0)
+#include <dune/common/parallel/collectivecommunication.hh>
+#else
 #include <dune/common/collectivecommunication.hh>
+#endif

The Finddune-cornerpoint.cmake file relies on a cmake_cxx_source_compiles. It tries to include a cornerpoint header file, however, cornerpoint determines which file to include depending on a version flag set by Dune. In the compile-test this version does not seem to be set properly, and fresh builds will fail with a HAVE_DUNE_CORNERPOINT error message.

Confirmed by manually inserting Dune common and Dune grid major version directives in the test snippet.

Two solutions immediately comes to mind; either make some changes to the build system so these variables get set during feature-testing or simply negate the #if to check for versions -older- than 3.0 rather than newer. The latter will of course give the same issue when compiling a recent opm against an older Dune, but this might not be a real world issue.

Any ideas?

_______________________________________________
Opm mailing list
[email protected]
http://www.opm-project.org/mailman/listinfo/opm

Reply via email to