Title: Re: [Oscar-devel] OS_Detect framework
I actually kind of like the idea of splitting up the versions - because I was thinking that when we remove support for Fedora Core 2 (in trunk), I'll need to edit the file and potentially make a mistake (!!) - much easier to just delete the file when we remove support.
 
Jeff, what say you?
 
Cheers,
 
Bernard


From: Erich Focht [mailto:[EMAIL PROTECTED]
Sent: Tue 25/10/2005 00:24
To: [email protected]
Cc: Bernard Li; Jeff Squyres
Subject: Re: [Oscar-devel] OS_Detect framework

On Monday 24 October 2005 23:44, Bernard Li wrote:
> > REMEMBER: We decided to make OS_Detect be, quite literally, the
> > gatekeeper for all OSCAR supported systems.  Specifically, if
> > OS_Detect
> > says that this is an unsupported system, then install_cluster will
> > refuse to run.  Hence, the modules in OS_Detect must be
> > updated when we
> > include support for a new system (e.g., write a short
> > CentOS.pm and/or
> > ScientificLinux.pm and/or ...).
>
> I remember when we discussed this previously, we wanted to be able to
> allow the user to say well CentOS is similar to RHEL4, and since RHEL4
> is supported, then CentOS should work too...  how should we handle these
> cases?  Would the user be required to write a .pm file for the
> framework?

I suggest we add a field which shows to which distros we aer compatible.
So Centos.pm would create:
    linux_distro => "centos",
    linux_distro_version => $centos_release,
and (NEW)
    compat_distro => "redhat",
    compat_distro_version => $centos_release,

compat_distro_version might need some "translation". The generic-setup thing
would then use the compat_distro, and if it doesn't find it, the linux_distro
entry. Or the other way round.

Actually I'd prefer to split up Fedora.pm into Fedora3.pm, Fedora4.pm,
etc. When we remove support for a distro, we simply remove the .pm file. Same
for Redhat, instead of building complicated ifdefs into the .pm file (for
recognising the different version strings), it is easier to split them up
across the single files like rhel3.pm, rhel4.pm. The if-block is implicitly
built into the OCA framework, no need to make the distro files recognize more
than one main version. If someone wants code reusage, we can easilly integrate
the common code into OS_Detect and simplify the distro.pm files later.

Regards,
Erich

Reply via email to