On 9/28/07, Smeenk, R.J.M. (Roland) <[EMAIL PROTECTED]> wrote: > Robert, > > Yes, that was one of my thoughts too, but in that case we need to add > support for handling mipmap levels per depth level.
Yes I can see that now. I have done a quick review of all the changes and am concern by the extent of them, and the potential for breaking code. I do value the ability to load cubeamps a single image so am torn. There are two areas of potential breakage, first up is user code that currently relies upon TextureCubeMap uses six separate images. This code will break with your changes which is a bad thing, this close to a stable release this unacceptable. Might I suggest supporting both six separate 2D images or one single 2D with 6 faces image. Second up is the runtime stablity of the new changes. My initial test suggests that they might be OK, but only far more extensive testing with end user apps will be able to determine this. However, we can start on this until the above is resolved. Could you please have a look at modifiying TextureCubeMap so old code will still work with it, and provide the new Image support as an additional option for it. Until this is in place I won't merge the changes. Cheers, Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
