Hi Robert, > > In my opinion all we need to do is support the old functionality > > through the old interfaces. This doesn't mean that we > cannot use the > > new datastructure for supporting the old way of working. In two > > complete code paths would you also want to store the data in two > > separate locations? > > To support the old method you have to support both get and > set as they were before.
You mean completely reverting to the old implementation? I can do that, but do you also want to bring back reading and writing of old .ive and .osg files and not automatically update to the new data structure? And TextureCubeMap::apply would have to change to support both the single 6 face image and the array of images depending on which data is filled in. That feels like a shakier solution. > > For easing porting of old applications we could also add an osgUtil > > class that can compile a new 6 face image from 6 single images and > > vice versa. > > This helper class could also be used in TextureCubeMap and the .osg > > and .ive readerwriter, but I don't know if this introduces > new dependencies. > > I am trying to get 2.2 out the door. This means not rocking > the boat introducing extra steps that users have to jump through. > > If it weren't so close to 2.2 I would be more relaxed about > this stuff. Right now the changes you've made feel way too > intrusive to risk it. Ok, I understand, but I am not trying to introduce new steps. It's just a helper for porting from the old way to the new way of working with cubemaps. Both ways are still available and working. I don't know what the timeframe for 2.2 is, but for what version would you be more comfortable with adding these changes? In that case it would probably be good to also update TextureArray to use multi face images. -- Roland This e-mail and its contents are subject to the DISCLAIMER at http://www.tno.nl/disclaimer/email.html _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
