Robert, > There are two areas of potential breakage, first up is user code that > currently relies upon TextureCubeMap uses six separate images. This > code will break with your changes which is a bad thing, this > close to a stable release this unacceptable. Might I suggest > supporting both six separate 2D images or one single 2D with > 6 faces image.
I am aware of this and that's why I changed the example vertexprogram to handle the new interface of TextureCubeMap as an example of the changes needed (basically throwing out code). > Second up is the runtime stablity of the new changes. My > initial test suggests that they might be OK, but only far > more extensive testing > with end user apps will be able to determine this. However, we can > start on this until the above is resolved. Do you mean the impact of these changes so close before 2.2? > Could you please have a look at modifiying TextureCubeMap so > old code will still work with it, and provide the new Image > support as an additional option for it. Until this is in > place I won't merge the changes. OK, I will make TextureCubeMap backwards compatible and modify the vertexprogram to show both options of usage. What's the best way to indicate that they are deprecated (besides doxygen comments)? Roland This e-mail and its contents are subject to the DISCLAIMER at http://www.tno.nl/disclaimer/email.html _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
