Hu Sukender,

On Wed, Dec 3, 2008 at 9:22 AM, Sukender <[EMAIL PROTECTED]> wrote:
> Err... I don't uderstand... My methods don't add any pointer since I actually 
> chain callbacks (I add a nested callback in the existing callback)... Did I 
> miss something?

No, I missed something, I did a quick reply without reviewing your
changes, I assumed that had come up with a parallel mechanism to the
existing one, but now on actually reviewing the changes you are just
providing convenience wrappers for it so it's just an issue of whether
the new methods fit with the "Minimal yet Complete" hurdle that I put
up against new additions.

The current API set/get is certainly minimal, and technically is
complete as you can achieve what you are doing without the extra API.
I would however admit that the chaining functionality of NodeCallback
is probably something that many users will overlook.  Your methods
would make this functionality more obvious so I can see value in them.

I can't merge without knowing your name though.... all contributors
get credited :-)

Robert.
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to