Hi Michael, Yes, your change is okay, even if I personnally would prefer: Writing support added 2009 by Thibault Caporal and Sukender (Benoit Neil - http://sukender.free.fr) But this is absolutely not important ;)
Did you make any other change? Thanks for the review. Sukender PVLE - Lightweight cross-platform game engine - http://pvle.sourceforge.net/ ----- "Michael Platings" <[email protected]> a écrit : > Hi Sukender, > thanks for the submission. I've made some alterations and I'll commit > to SVN just as soon as Jose Luis gives me write access. > > The comment at the start of WriterNodeVisitor is unclear: > Writing support added 2007 by Capo (Thibault CAPORAL), > http://sukender.free.fr , > strongly inspired by the FBX writer object by Benoit NEIL and myself > the FBX reader. > > I've simplified it to: > Writing support added 2009 by Thibault Caporal and Benoit Neil ( > http://sukender.free.fr ) > is that correct? > > Cheers > -Michael > > > 2009/12/15 Sukender < [email protected] > > > > Hi Robert, > > FBX plugin update: > - Added write support > - Fixed handling of "default stateset" > - Fixed handling of duplicated materials/statesets > - Fixed handling of coordinate system/axis > > Changes are against trunk rev. 10898. > Happy reviewing! :) > > Sukender > PVLE - Lightweight cross-platform game engine - > http://pvle.sourceforge.net/ > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > > > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
