Hi Marcin,

I've just merged and submitted your changes to svn/trunk.  To the
Texture2DMultisample::apply() I have added the lines:

    if (!extensions->isTextureMultisampledSupported())
    {
        OSG_INFO<<"Texture2DMultisample not supoorted."<<std::endl;
        return;
    }

So that it won't crash on system that don't support this extension.  I
also noteed from the texture_multisample.txt specs:

   http://www.opengl.org/registry/specs/ARB/texture_multisample.txt

That glSampleMaski isn't yet used in your implementation.  I think it
would be appropriate to add this. Unfortunately I don't have a GL3
capable card/drivers yet so can't test it, so I'll defer to yourself
or others with this capability to complete.

There also isn't any serialization support yet in this submission.  I
presume as things stand it's not critical, but for completeness this
would be appropriate to add.  I don't see a need to add support the
deprecated .osg and .ive formats though, only the new serialization
support need be tackled.

Cheers,
Robert.

On Wed, Apr 14, 2010 at 3:21 PM, Marcin Hajder <[email protected]> wrote:
> Hi,
>
> Fixed. According to ARB_texture_multisample extension specification 
> multisample textures  don't need TexParameters since they can only be fetched 
> with  texelFetch.
>
> Cheers,
> Marcin
>
> ------------------
> Read this topic online here:
> http://forum.openscenegraph.org/viewtopic.php?p=26777#26777
>
>
>
>
> Attachments:
> http://forum.openscenegraph.org//files/texture2dmultisample_102.zip
>
>
> _______________________________________________
> osg-submissions mailing list
> [email protected]
> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
>
_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to