Hi Terry, I have now started reviewing your submission. The changes to src/osgWrappers/deprecated-dotosg/osg/Shader.cpp and src/osgPlugins/glsl/ReaderWriterGLSL.cpp all look uncontroversial so have merged these and once we are a bit further along with the review will check this in. The changes to FileUtils.cpp's osgDB::findFileInPath(const std::string& filename, const FilePathList& filepath,CaseSensitivity caseSensitivity) and Regisytry.cpp's ReaderWriter::ReadResult Registry::read(const ReadFunctor& readFunctor) feel a bit awkward to me.
Could you explain the changes you've made and what usage case you were working to solve with these changes. I need to get my head around that changes before I merge. I'm may well decide to refactor the changes, but can't decide upon this until I know what you are attempting to do. I also need to have a good think about the potential consequences of the changes on other usage models as these bits of code and heavily used by many users. Could you also give me some pointers of how to recreate the usage you using so I can recreate this at my end. Cheers, Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
