Hi Terry, On 3 February 2012 07:22, Terry Welsh <[email protected]> wrote: > Hi Robert, > Your reordering of steps looks fine. I fixed some errors and attached > a new Registry.cpp.
Thanks for the fixes, I'll match the ones that changed to use path rather than readFunctor._filename but the others I don't think are appropriate. See below. > You are searching readFunctor._options->getDatabasePathList() where I > was just using findDataFile(). findDataFile() will search > readFunctor._options->getDatabasePathList(), but it will also search > Registry::instance()->getDataFilePathList() and it will try filenames > chopped by getSimpleFileName(). These are two cases where your new > Registry.cpp was failing. I switched it back to using findDataFile() > and all my test cases work again. Is there some reason you wanted to > avoid using that function? I'm not happy with a general file search being done when it's only the file paths that contain a reference to an archive that we are interested in - this is why I string out the search to just the Options::DatabaseFilePathList. You are correct that this misses searching the Registry::DataFileList and trying simplifications to the name. I will have a think about this aspect. Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
